Jira Reviewer Responsibilities

Not logged in

• Browse
• Help
• Home
• Login
• Reports
• Search
• Timeline
• Wiki

• Contents
• No-Diff
• Text

 *: Verify that the jira ticket has a target version number and that it is correct
 *: Verify that the jira ticket is in review status
 *: review the pull request and approve (or disapprove)
+*:: Verify that the Jira ticket is mentioned at the beginning of the title. Edit it, if not
+*:: check for correctness of change
 *:: verify that the destination of the pull request matches the target version of the ticket
 *:: check for documentation
 *:: check for version history
 *:: check batlab dashboard for successful build and test for either the pull request or a workspace build by the developer that has the jira ticket as a comment.
-*:: check for correctness of change
 *:: check that commit message references the jira ticket (HTCONDOR-xxx)
 *: hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional review)
 *: take the ticket out of review state and assign back to the developer

This work is supported by NSF under Cooperative Agreement OAC-2030508 as part of the PATh Project. Any opinions, findings, and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the NSF. Site built using CVSTrac.